Ver código fonte

null password issue fix
do not allow login with empty password

fengchang 1 ano atrás
pai
commit
d86e609dec

+ 2 - 1
hichina-main-back/src/main/java/com/hichina/main/back/hichinamainback/config/CustomAuthenticationProvider.java

@@ -3,6 +3,7 @@ package com.hichina.main.back.hichinamainback.config;
 import com.hichina.main.back.hichinamainback.mapper.UserMapper;
 import com.hichina.main.back.hichinamainback.model.User;
 import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.security.authentication.AuthenticationProvider;
 import org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
@@ -30,7 +31,7 @@ public class CustomAuthenticationProvider implements AuthenticationProvider {
         String name = authentication.getName();
         String password = authentication.getCredentials().toString();
 
-        if(name.contains(",")){
+        if(name.contains(",") || StringUtils.isEmpty(password)){
             return null;
         }
 

+ 1 - 0
hichina-main-back/src/main/java/com/hichina/main/back/hichinamainback/config/FacebookAuthProvider.java

@@ -30,6 +30,7 @@ public class FacebookAuthProvider implements AuthenticationProvider {
             user.setCreatedTime(new Date());
             user.setSalt(CustomAuthenticationProvider.generateSalt());
             user.setUsername(name);
+            user.setPassword("");
             user.setEmail(email);
             user.setFacebookId(fbId);
             user.setProfileImageUrl(profileImageUrl);